On Mon, Oct 17, 2022 at 02:04:13PM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > Really, both here and remove_redundant_pack() should probably be using > > unlink_or_warn(). Though if you did want to notice the race on deleting > > the actual .pack file, it would need to be hand-coded. > > Yeah, unlink_or_warn() would probably be the right way to go. > > Other than that, the patch looks good to you folks? Yeah. I suggested a minor reordering of the one change, but the substance of the patch looks good to me (and I am OK either way on the little suggestions). -Peff
