On 10/14/2022 12:15 PM, Junio C Hamano wrote: > "nsengaw4c via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > >> From: Nsengiyumva Wilberforce <nsengiyumvawilberforce@xxxxxxxxx> >> >> Tests in this script use an unusual and hard to reason about >> conditional construct >> >> if expression; then false; else :; fi >> >> Change them to use more idiomatic construct: >> >> ! expression >> >> Cc: Christian Couder <christian.couder@xxxxxxxxx> >> Cc: Hariom Verma <hariom18599@xxxxxxxxx> >> Signed-off-by: Nsengiyumva Wilberforce <nsengiyumvawilberforce@xxxxxxxxx> > > What are these C: lines for? I do not think the message I am > responding to is Cc'ed to them. There may be a special incantation > to tell GitGitGadget to Cc to certain folks, but adding Cc: to the > log message trailer like this does not seem to be it---at least it > appears that it did not work that way. GitGitGadget will read the "cc:" lines from the end of the pull request description, not the commit messages. I'm pretty sure they will be ignored if there are other lines after them. Thanks, -Stolee
