"nsengaw4c via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > From: wilberforce <nsengiyumvawilberforce@xxxxxxxxx> This name must match ... > Tests in this script use an unusual and hard to reason about > conditional construct > > if expression; then false; else :; fi > > Change them to use more idiomatic construct: > > ! expression > > Cc: Christian Couder <christian.couder@xxxxxxxxx> > Cc: Hariom Verma <hariom18599@xxxxxxxxx> > Signed-off-by: Nsengiyumva wilberfore <nsengiyumvawilberforce@xxxxxxxxx> ... the name you sign-off your work with. > - if read_tree_u_must_succeed -m -u $treeH $treeM; then false; else :; fi' > + ! read_tree_u_must_succeed -m -u $treeH $treeM' OK.