"Jeff Hostetler via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
> From: Jeff Hostetler <jeffhost@xxxxxxxxxxxxx>
>
> Rename the `thread_name` argument in `tr2tls_create_self()` and
> `trace2_thread_start()` to be `thread_base_name` to make it clearer
> that the passed argument is a component used in the construction of
> the actual `struct tr2tls_thread_ctx.thread_name` variable.
>
> The base name will be used along with the thread id to create a
> unique thread name.
> ...
> -struct tr2tls_thread_ctx *tr2tls_create_self(const char *thread_name,
> +struct tr2tls_thread_ctx *tr2tls_create_self(const char *thread_base_name,
> uint64_t us_thread_start)
> {
> struct tr2tls_thread_ctx *ctx = xcalloc(1, sizeof(*ctx));
> @@ -50,7 +50,7 @@ struct tr2tls_thread_ctx *tr2tls_create_self(const char *thread_name,
> strbuf_init(&ctx->thread_name, 0);
> if (ctx->thread_id)
> strbuf_addf(&ctx->thread_name, "th%02d:", ctx->thread_id);
> - strbuf_addstr(&ctx->thread_name, thread_name);
> + strbuf_addstr(&ctx->thread_name, thread_base_name);
> if (ctx->thread_name.len > TR2_MAX_THREAD_NAME)
> strbuf_setlen(&ctx->thread_name, TR2_MAX_THREAD_NAME);
This hunk is very illustrative and highlights the difference between
thread_base_name parameter and .thread_name member in the context.
Good.
