Calvin Wan <calvinwan@xxxxxxxxxx> writes: > Hi Ævar > > Thank you for condensing the patch series into something more palatable > for reviewers. The general consensus from the review club yesterday (we > looked at v2) was that it was difficult to follow what patches were > relevant to your original intention and what patches were auxiliary QOL > changes. Also having too many intermediary patches where you add > variables/functions that were later deleted made it hard to visualize > which parts of the patch would end up making it into the final state. I > appreciate the "show your work" approach you take, but I think that > approach is better suited for more difficult patch series where there > are significant/difficult to understand functionality changes. In this > case, the end state of a refactor is clear and there are no > functionality changes so I believe a more condensed series would be > easier to review. That being said, I don't believe there is a need to > spend more time trying to condense this series so future reviewers have > an easier time -- the end result and intentions are enough. > > Reviewed-by: Calvin Wan <calvinwan@xxxxxxxxxx> Thanks, both.
