Fix a "-h" output syntax issue introduced when "--diagnose" was added in aac0e8ffeee (builtin/bugreport.c: create '--diagnose' option, 2022-08-12): We need to close the "[" we opened. The corresponding *.txt change did not have the same issue. The "help -h" output then had one "]" too many, which is an issue introduced in b40845293b5 (help: correct the usage string in -h and documentation, 2021-09-10). Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> --- builtin/bugreport.c | 2 +- builtin/help.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin/bugreport.c b/builtin/bugreport.c index 23170113cc8..bb138161943 100644 --- a/builtin/bugreport.c +++ b/builtin/bugreport.c @@ -61,7 +61,7 @@ static void get_populated_hooks(struct strbuf *hook_info, int nongit) static const char * const bugreport_usage[] = { N_("git bugreport [(-o|--output-directory) <file>] [(-s|--suffix) <format>]\n" - " [--diagnose[=<mode>]"), + " [--diagnose[=<mode>]]"), NULL }; diff --git a/builtin/help.c b/builtin/help.c index 6f2796f211e..53f2812dfb1 100644 --- a/builtin/help.c +++ b/builtin/help.c @@ -88,7 +88,7 @@ static struct option builtin_help_options[] = { }; static const char * const builtin_help_usage[] = { - "git help [-a|--all] [--[no-]verbose]] [--[no-]external-commands] [--[no-]aliases]", + "git help [-a|--all] [--[no-]verbose] [--[no-]external-commands] [--[no-]aliases]", N_("git help [[-i|--info] [-m|--man] [-w|--web]] [<command>|<doc>]"), "git help [-g|--guides]", "git help [-c|--config]", -- 2.38.0.1085.gb7e61c3016c