Re: [PATCH] abspath.h file is generated by makeheaders tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 12 2022, skrab-sah via GitGitGadget wrote:

> From: skrab-sah <skrab.sah@xxxxxxxxx>
>
> 1. We don't need to commit the file.
> 2. Added routin for abspath.c in Makefile.
> 3. Added tool support for makeheaders.
>
> Signed-off-by: skrab-sah <skrab.sah@xxxxxxxxx>

Not to repeat earlier feedback, but I really think you need to read &
internalize some of it rather than keep submitting these:
https://lore.kernel.org/git/?q=skrab-sah

Not commenting on much of this, except:

> @@ -1,5 +1,21 @@
>  # The default target of this Makefile is...
> -all::
> +all:: hdr
> +
> +
> +# In parallel mode things goes up and down.
> +.NOTPARALLEL:

I think this really goes to what i was pointing out in
https://lore.kernel.org/git/220923.861qs25yr8.gmgdl@xxxxxxxxxxxxxxxxxxx/

You're making very fundimental changes to a subsystem that your changes
themselves show you clearly don't understand that well.

Firstly, we have a lot of things in this makefile which don't require C
compilation, so putting a "hdr" as an "all" dependency is a no-go.

Secondly, you've globally marked our Makefile as "nothing here can run
in parallel", i.e. the single biggest slowdown it's ever had, presumably
because you got some dependency chain wrong, and are usin git as a
workaround.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux