On Tue, Oct 11 2022, Calvin Wan wrote:
Just commenting on one case, but this is in other parts of the series
(e.g. your additions in submodule.c):
> + BUG("invalid status --porcelain=2 line %s",
> + buf);
> [...]
> - BUG("invalid status --porcelain=2 line %s",
> - buf.buf);
Your editor's indentation settings need fixing. Arguments should align
with the opening "(", here you replaced 4 spaces with a "\t".
A "\t" is == 8 spaces for the purposes of our identation, if you need 7
spaces to align with the "7" you insert 7 spaces, if it's 8 a "\t", then
for one more a "\t" and one space etc.
