On Tue, Oct 11 2022, Ævar Arnfjörð Bjarmason wrote: > On Mon, Oct 10 2022, Taylor Blau wrote: >> +void shortlog_init_group(struct shortlog *log) >> +{ >> + if (!log->groups) >> + log->groups = SHORTLOG_GROUP_AUTHOR; >> + >> + if (log->groups & SHORTLOG_GROUP_AUTHOR) > > Nit (easier reading): > > if (!x) > ... > else if (x & FLAG) > ... Urgh, sorry about the noise. That's an obvious logic error, I don't know what I was thinking...