On Mon, Oct 10, 2022 at 08:34:05PM -0400, Taylor Blau wrote:
> From: Jeff King <peff@xxxxxxxx>
>
> Prepare for the future patch which will introduce arbitrary pretty
> formats via the `--group` argument.
>
> To allow additional customizability (for example, to support something
> like `git shortlog -s --group='%aD' --date='format:%Y-%m' ...` (which
> groups commits by the datestring 'YYYY-mm' according to author date), we
> must store off the `--date` parsed from calling `parse_revision_opt()`.
Sorry, I haven't had a chance yet to look carefully at the rest of the
shortlog discussion, but I wanted to note here: this patch also affects
custom output formats. So:
- we probably want to note that in the commit message as a limitation
of this, versus something like %(authordate:format=...). I think
that's fine, as the same limitation already applies to multiple
dates in a single format string.
- it's arguably a bug-fix, and can be tested in isolation like:
git shortlog --format='%ad %s' --date=short
which currently ignores the --date option entirely.
-Peff
