Hi, On Thu, 11 Oct 2007, Jonathan del Strother wrote: > On 11 Oct 2007, at 21:53, David Kastrup wrote: > > > Johannes Sixt <j.sixt@xxxxxxxxxxxxx> writes: > > > > > Jonathan del Strother schrieb: > > > > How are you going to test that git works on paths with spaces if the > > > > test suite doesn't run there? > > > > > > By writing a specific test? > > > > This is going to be much less thorough. And it does no harm if the > > test scripts demonstrate defensive programming. We do not have _extensive_ tests. We want to do some coding in addition to waiting for our machines to finish the test. D'oh. > I would also point out that most tests have already been written to > handle this case - ones that don't quote their paths are in the > minority. That might very well be the case, and your goal is laudable. However, I have to agree that most devs (indeed, since you are the first to try to fix it, _all_ except for you) do not care that deeply about spaces in the path, and having a _single_ test for this would be the logical solution. I mean, we do not force our main developers to run the most obscure setups all the time just to make sure that it runs fine. Otherwise none of us could run Linux, but a couple would be coerced into running Windows, for example. Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
