Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes:
>>> The common pattern for run_command_v_opt() callers that don't need a
>>> dynamic list is exactly that.
So, scratching "that don't need a dynamic list", and with ...
> Other prior art, just taking the char[] ones (and not even all of them):
> ...
> builtin/merge-index.c:12:37: error: initializer element is not computable at load time [-Werror=pedantic]
> 12 | const char *arguments[] = { pgm, "", "", "", path, "", "", "", NULL };
> builtin/remote.c:95:41: error: initializer element is not computable at load time [-Werror=pedantic]
> 95 | const char *argv[] = { "fetch", name, NULL, NULL };
> archive.c:408:33: error: initializer element is not computable at load time [-Werror=pedantic]
> 408 | const char *paths[] = { path, NULL };
> merge-ort.c:1699:45: error: initializer element is not computable at load time [-Werror=pedantic]
> 1699 | "--all", merged_revision, NULL };
... these, I agree that we are not making anything worse.
Thanks.
