On Thu, Oct 6, 2022 at 4:41 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > "Jeff Hostetler via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > > This patch series fixes three syntax errors that caused compiler errors with > > clang 11.0.0 on MacOS. I've included the error/warning messages in the > > commit messages. The offending statements did compile successfully under > > clang 14.0.0 on MacOS, so I have to assume that this usage is newer than > > what clang 11 supports. > > Ah, this looked familiar, and the last time we saw the one in > builtin/unpack-objects.c > > https://lore.kernel.org/git/20220710081135.74964-1-sunshine@xxxxxxxxxxxxxx/ > > It seems that merge-file.c was OK back then but soon after we > "broke" it with 480a0e30 (merge-file: refactor for subsequent memory > leak fix, 2022-07-01). For completeness, the merge-file.c instance also got reported: https://lore.kernel.org/git/365e01e93dce582e9d926e83bdc6891310d22699.1659084832.git.congdanhqx@xxxxxxxxx/