> -----Original Message----- > From: Junio C Hamano <jch2355@xxxxxxxxx> On Behalf Of Junio C Hamano > Sent: Wednesday, October 5, 2022 2:05 PM > To: Eric DeCosta via GitGitGadget <gitgitgadget@xxxxxxxxx> > Cc: git@xxxxxxxxxxxxxxx; Jeff Hostetler <git@xxxxxxxxxxxxxxxxx>; Eric Sunshine > <sunshine@xxxxxxxxxxxxxx>; Torsten Bögershausen <tboegi@xxxxxx>; > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>; Ramsay Jones > <ramsay@xxxxxxxxxxxxxxxxxxxx>; Johannes Schindelin > <Johannes.Schindelin@xxxxxx>; Eric DeCosta <edecosta@xxxxxxxxxxxxx> > Subject: Re: [PATCH v15 0/6] fsmonitor: option to allow fsmonitor to run > against network-mounted repos > > "Eric DeCosta via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > > > An additional issue is that for mount points in the root directory, > > FSEvents does not report a path that matches the worktree directory > > due to the introduction of 'synthetic firmlinks'. fsmonitor must map > > the FSEvents paths to the worktree directory by interrogating the root > > filesystem for synthetic firmlinks and using that information to translate the > path. > > > > v15 differs from v14: > > > > * fix memory leak > > Thanks. I thought "what, another iteration? didn't we see this enough times > already?" and a note like this does help reminding reviewers why we need > one. > > Very much appreciated. Thanks. Just getting better at doing the right thing as I climb up the learning curve :) Hopefully it is in a state where it is now GTM. -Eric
