"Derrick Stolee via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
> +static int unbundle_all_bundles(struct repository *r,
> + struct bundle_list *list)
> +{
> + /*
> + * Iterate through all bundles looking for ones that can
> + * successfully unbundle. If any succeed, then perhaps another
> + * will succeed in the next attempt.
> + *
> + * Keep in mind that a non-zero result for the loop here means
> + * the loop terminated early on a successful unbundling, which
> + * signals that we can try again.
> + */
> + while (for_all_bundles_in_list(list, attempt_unbundle, r)) ;
> +
> + return 0;
> +}
This function always returns 0 regardless of how many successful
iterations there were: we would need the number to be equal to the
number of bundles in the list if ALL, and 1 if ANY.
Which brings up the question...we probably need a test for when the
unbundling is unsuccessful.
Other than that, everything looks good, including the removal of one
patch and the addition of the "bundle-uri: suppress stderr from
remote-https" patch.
