Jeff King <peff@xxxxxxxx> writes: > On Mon, Oct 03, 2022 at 01:27:37PM -0400, Jeff King wrote: > >> -check_broken_author 'unknown key in author-script' ' >> +test_expect_success 'unknown key in author-script' ' >> + create_conflict && >> + >> echo "GIT_AUTHOR_BOGUS=${SQ}whatever${SQ}" \ >> - >>.git/rebase-merge/author-script' >> + >>.git/rebase-merge/author-script && >> >> + check_resolve_fails >> +' >> >> test_done >> >> That makes the boilerplate shorter in the "-v" output but focuses on the >> actual modification that breaks the author-script. > > Note that we do still keep the ${SQ} bits here. They're necessary for > the same reason: before and after a snippet is being passed through a > variable. Whereas in yours we'd use stdin. I _do_ like that approach in > general, but it is unlike the rest of the test suite. Maybe it's worth > resurrecting: > > https://lore.kernel.org/git/YHDUg6ZR5vu93kGm@xxxxxxxxxxxxxxxxxxxxxxx/ > > ? Yeah, it is indeed quite tempting.