Let me add, to my other reply to this.. On 30/9/22 0:26, Junio C Hamano wrote: >> But.. do we want to implement this this way? Maybe we will have to >> implement on purpose this feature in some future refactorization? > > Absolutely. It is simpler and there is not much downside. Once I realize this is porcelain, I strongly agree with this. The TOCTOU might be resolved, perhaps outside the scope of this patch, warning the user or not allowing two concurrent editions. Maybe... :-) even I would dig deeper in the TOCTOU, avoiding the call to git_config_set if no change has been made to the branch description. Anyway, as it is, it's good, imo. Simple and resolves a confuse error removing it. Nice. > The official stance is "if it hurts, do not do it then". The side > discussion about TOCTOU was to see how much hurt we are making the > user responsible for, and explaining that it is not that much. >
