> You mean the internal "struct parallel_processes"? How do you get the > parameter there, presumably by passing it to > run_processes_parallel{,_tr2}() as a new parameter? Yea I added it as a new parameter... > The reason for why the "ungroup" wasn't added as a parameter at the time > was to avoid the churn of changing every single caller of the API. > > But it should really be a "parameter", and doing it via a struct means > adding such parameters doesn't need to change every single caller. > > Then we have outstanding WIP patches for the hook.[ch] API which needed > to add two other parameters... > > So I think first ripping off the band-aid of making it painless to > extend the interface is the right thing to do, unless I've missed some > way of doing it that you've just discovered... In that case my patch does depend on yours for resubmission, so it sounds like if I want to quickly resubmit then I should cherry-pick the relevant commits from your WIP branch.