Frank Lichtenheld wrote:
On Wed, Oct 10, 2007 at 01:16:03PM +0200, Jan Wielemaker wrote:
+ # if we have a -p we should just send the file
+ if ( exists ( $state->{opt}{p} ) )
+ {
+ if ( open my $fh, '-|', "git-cat-file", "blob", $meta->{filehash} )
+ { while ( <$fh> )
+ { print "M " . $_;
+ }
+ close $fh or die ("Couldn't close filehandle for transmitfile(): $!");
+ } else
+ { die("Couldn't execute git-cat-file");
+ }
+
+ next;
+ }
There seems to be inconsistent whitespace in the patch.
And please never do that else\n{ again, it hurts my eye ;)
That cuddled opening brace hurts mine more.
{ while()\n{ print()...
It's usually a good idea to pick some indentation style that at least *some* tool
can create, and when contributing to a project it's usually considered good form
to stick to the style already used.
--
Andreas Ericsson andreas.ericsson@xxxxxx
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
