On Wed, Sep 28, 2022 at 9:13 AM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > > Hi, there's an outstanding patch of mine queued in "seen" that fixes the > same issue. I sent a re-roll of it after you submitted this (but the v1 > had been in "seen". See: > https://lore.kernel.org/git/patch-v2-17.35-97873747a1e-20220928T082458Z-avarab@xxxxxxxxx/ Thanks! It looks like you caught a lot more inconsistencies than I did. Let's forget about my patch and just wait for yours to be merged. > Per that change I think the right thing here is to convert both to use > "<path>". > > I don't really have a strong opinion per-se on if we use "<dir>" or > "<path>", but from grepping around the latter seems more common, even in > cases where we mean "a path that's only a dir". My main concern is that the usage string says that `git bugreport -o` expects a file when in fact it expects a directory. I don't have a strong opinion on whether the usage string should say <dir> or <path>; either is more correct than <file>. -Alex
