> -----Original Message----- > From: Eric Sunshine <sunshine@xxxxxxxxxxxxxx> > Sent: Monday, September 26, 2022 10:16 PM > To: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> > Cc: Eric DeCosta via GitGitGadget <gitgitgadget@xxxxxxxxx>; Git List > <git@xxxxxxxxxxxxxxx>; Jeff Hostetler <git@xxxxxxxxxxxxxxxxx>; Torsten > Bögershausen <tboegi@xxxxxx>; Ramsay Jones > <ramsay@xxxxxxxxxxxxxxxxxxxx>; Johannes Schindelin > <Johannes.Schindelin@xxxxxx>; Eric DeCosta <edecosta@xxxxxxxxxxxxx> > Subject: Re: [PATCH v12 6/6] fsmonitor: add documentation for allowRemote > and socketDir options > > On Mon, Sep 26, 2022 at 11:15 AM Ævar Arnfjörð Bjarmason > <avarab@xxxxxxxxx> wrote: > > On Sat, Sep 24 2022, Eric DeCosta via GitGitGadget wrote: > > > Add documentation for 'fsmonitor.allowRemote' and > 'fsmonitor.socketDir'. > > > Call-out experimental nature of 'fsmonitor.allowRemote' and limited > > > file system support for 'fsmonitor.socketDir'. > > > > > > Signed-off-by: Eric DeCosta <edecosta@xxxxxxxxxxxxx> > > > --- > > > -git-fsmonitor--daemon - A Built-in File System Monitor > > > +git-fsmonitor--daemon - A Built-in Filesystem Monitor > > > > We have ~400 uses of "filesystem" in-tree, but ~100 for "file system". > > I don't mind the change per-se, but this looks like an odd "while at it" > > change. > > > > > A daemon to watch the working directory for file and directory > > > -changes using platform-specific file system notification facilities. > > > +changes using platform-specific filesystem notification facilities. > > > > More while-at-it... > > These changes may have been in response to my review[1], though I did say > that such a change was outside the scope of this series. Perhaps I need to > choose my wording more carefully? > > [1]: https://lore.kernel.org/git/CAPig+cQ5SMw+0Cwtw47LQM59- > mQjJaOPe_LTybAC2j=3F9OywA@xxxxxxxxxxxxxx/ <https://protect- > us.mimecast.com/s/STwOCG6A7DIYgAqYc7Wdth?domain=lore.kernel.org> > Your wording was fine. Next time I'll know better and leave it for another patch set. -Eric
