On Sat, Sep 24 2022, Eric DeCosta via GitGitGadget wrote:
> From: Eric DeCosta <edecosta@xxxxxxxxxxxxx>
> [...]
> @@ -281,9 +283,11 @@ char *fsm_settings__get_incompatible_msg(const struct repository *r,
> goto done;
>
> case FSMONITOR_REASON_NOSOCKETS:
> + socket_dir = dirname((char *)fsmonitor_ipc__get_path(r));
> strbuf_addf(&msg,
> - _("repository '%s' is incompatible with fsmonitor due to lack of Unix sockets"),
> - r->worktree);
> + _("socket directory '%s' is incompatible with fsmonitor due"
> + " to lack of Unix sockets support"),
> + socket_dir);
Could do with less "while at it" here. We are:
* Wrapping the string, making the functional change(s) harder to spot.
* replacing r->worktree with socket_dir
* Adding " support" to the end of the string, and replacing "repository" with "socket directory"
AFAICT the continuation of the string isn't indented in the way we
usually do, i.e. to align with the opening ".
