Junio C Hamano <gitster@xxxxxxxxx> writes:
> "Derrick Stolee via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
>
>
>> - trace2_region_enter("pack-bitmap", "reading_lookup_table", the_repository);
>> /* NEEDSWORK: cache misses aren't recorded */
>> bitmap = lazy_bitmap_for_commit(bitmap_git, commit);
>> - trace2_region_leave("pack-bitmap", "reading_lookup_table", the_repository);
>> if (!bitmap)
>> return NULL;
>> return lookup_stored_bitmap(bitmap);
>
> As "git blame" is bad in finding a piece of code that no longer
> exists, it may make sense to leave a comment around here why we do
> not have a trace2 region around this call, perhaps?
>
> + /* do not add trace2_region around here in the hot path */
> bitmap = lazy_bitmap_for_commit(...);
>
> or something?
>
> Thanks.
Also, we'd need to disable t5310.150 that expects to see
reading_lookup_table label in the trace.
