Re: [PATCH] refs: unify parse_worktree_ref() and ref_type()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Han-Wen Nienhuys <hanwen@xxxxxxxxxx> writes:

> On Mon, Sep 19, 2022 at 11:43 PM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> > On Tue, Sep 13, 2022 at 5:43 PM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> >> then a better approach would be to have a small helper
>> >> parse_local_worktree_ref() and make the primary one into something
>> >> like
>> >>...
>> >
>> > Thanks, good idea. I'm sending you a v2.
>>
>> is that "v2" <pull.1325.v2.git.git.1663605291172.gitgitgadget@xxxxxxxxx>
>> or is there another version of it?
>
> I think so.
>
>> Hmph,
>
> Did I do something wrong?

Not "wrong" per-se, but I was surprised by the patch that looked
quite different from what I expected from your response to the
"small helper" suggestion.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux