"Victoria Dye via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > From: Victoria Dye <vdye@xxxxxxxxxx> > > Add a reviewing guidelines document including advice and common terminology > used in Git mailing list reviews. The document is included in the > 'TECH_DOCS' list in order to include it in Git's published documentation. > > Helped-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > Helped-by: Derrick Stolee <derrickstolee@xxxxxxxxxx> > Helped-by: Junio C Hamano <gitster@xxxxxxxxx> > Helped-by: Josh Steadmon <steadmon@xxxxxxxxxx> > Signed-off-by: Victoria Dye <vdye@xxxxxxxxxx> > --- > Documentation: add ReviewingGuidelines > > This patch follows up on a discussion a few weeks ago in the Git IRC > standup [1], where it was mentioned that it would be nice to have > consistent definitions for common review terminology (like 'nit:'). The > "ReviewingGuidelines" document created here builds on that idea, as well > as past discussions around the idea of advice for reviewers (similar to > the guidelines for new contributors in MyFirstContribution [2]). Thanks. Will queue. I think this is ready for 'next' and then to 'master' during this cycle. Thanks for writing it, and thanks all for reviewing it.
