Derrick Stolee <derrickstolee@xxxxxxxxxx> writes: > On 9/19/2022 10:14 AM, Miaoqian Lin wrote: >> The function calls opendir() but missing the corresponding >> closedir() before exit the function. >> Add missing closedir() to fix it. > > Thanks for the patch, Miaoqian. > > I only have a very tiny nitpick with the line breaks in your > commit message. Either the "Add missing..." sentence should > start immediately after the previous sentence or have another > line break between the paragraphs. This shouldn't merit a > re-roll, but keep it in mind for future contributions. > >> out: >> + if(dir) >> + closedir(dir); >> strbuf_release(&path); >> } > > This change looks correct to me. Thanks! > -Stolee Thanks, both. Looking good.
