Hi, On Tue, 9 Oct 2007, Jeff King wrote: > On Tue, Oct 09, 2007 at 02:06:31PM +0100, Jonathan del Strother wrote: > > > For me at least, adding color would make the interactive mode far more > > readable. I hacked in basic color support (just coloring PROMPT & > > HEADER in list_and_choose, and the "Stage this hunk?" prompt) - which > > helped a lot - but then reached the limits of my perl knowledge. For > > instance, I can't see a sensible way of reusing git-svn's > > log_use_color function without importing the entire file, and I can't > > figure out how you'd go about diff-coloring the hunks. Is anyone with > > more perl knowledge than me interested in taking this on? > > Why don't you post what you have, and we can make comments on it? > > As far as reusing code from git-svn, there is a 'Git.pm' module in the > perl/ subdirectory. You can move the code there and 'use Git' in > git-add--interactive.perl (git-svn already uses it). I think the reason git-add--interactive does not use it is that some people (me included) experienced heavy problems with perl modules. However, I do not recall to which extent they have been solved. I guess when git-add--interactive goes Git.pm and stops working for me, I'll do my famous "aargh, I'll just make it a builtin" song. Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
