> -----Original Message----- > From: Junio C Hamano <jch2355@xxxxxxxxx> On Behalf Of Junio C Hamano > Sent: Monday, September 12, 2022 3:38 PM > To: Eric DeCosta via GitGitGadget <gitgitgadget@xxxxxxxxx> > Cc: git@xxxxxxxxxxxxxxx; Jeff Hostetler <git@xxxxxxxxxxxxxxxxx>; Eric Sunshine > <sunshine@xxxxxxxxxxxxxx>; Torsten Bögershausen <tboegi@xxxxxx>; > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>; Ramsay Jones > <ramsay@xxxxxxxxxxxxxxxxxxxx>; Johannes Schindelin > <Johannes.Schindelin@xxxxxx>; Eric DeCosta <edecosta@xxxxxxxxxxxxx> > Subject: Re: [PATCH v5 0/4] fsmonitor: option to allow fsmonitor to run > against network-mounted repos > > Junio C Hamano <gitster@xxxxxxxxx> writes: > > >> Eric DeCosta (4): > >> fsmonitor: refactor filesystem checks to common interface > >> fsmonitor: relocate socket file if .git directory is remote > >> fsmonitor: avoid socket location check if using hook > >> fsmonitor: deal with synthetic firmlinks on macOS > > > > It looks like this one is organized quite differently from the last > > iteration <pull.1326.v4.git.1661962145.gitgitgadget@xxxxxxxxx> > > Given that we are very close to -rc period, I am very tempted to say that this > follow-up effort can and should be separated out of the previous "windows > only" one, and we should merge the single patch that has been in 'next' to > 'master' without waiting for this "macOS, too" topic. What do people think? > > Thanks. I'm totally fine with that, turned out to be a bit more involved than I initially anticipated. -Eric
