Re: [PATCH] Support cvs via git-shell

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, 10 Oct 2007, Frank Lichtenheld wrote:

> On Tue, Oct 09, 2007 at 03:33:25PM +0100, Johannes Schindelin wrote:
> >  static struct commands {
> >  	const char *name;
> >  	int (*exec)(const char *me, char *arg);
> >  } cmd_list[] = {
> >  	{ "git-receive-pack", do_generic_cmd },
> >  	{ "git-upload-pack", do_generic_cmd },
> > +	{ "cvs", do_cvs_cmd },
> >  	{ NULL },
> 
> Maybe this should also allow git-cvsserver for completeness' sake?

Umm.  Why?

If you use a cvs client with :ext: protocol, it will call ssh (or rsh!) 
with the command "cvs server", not "git-cvsserver".

Only in setups where you set (IIRC) the environment variable "CVSSERVER" 
on the client to "git-cvsserver" will it call something different, but 
these setups exist already, and never used git-shell to begin with.

Ciao,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux