Victoria Dye <vdye@xxxxxxxxxx> writes: > I don't think it does more harm than good, but I wouldn't go so far as to > call it a definitive "net improvement." I'd personally very much prefer a > solution that didn't involve adding 'GIT-BUILD-DIR' just for the sake of > CMake. > ... > ... "switching between make & CMake" file staleness (if I'm not mistaken, the > same thing can happen now with the modified 'test-lib.sh', so this patch > doesn't really make anything worse), I do think the changes to 'test-lib.sh' > should be rearranged to preserve the "PANIC" check: Thanks for a quality review.
