Shawn,
On Oct 10, 2007, at 9:30 AM, Shawn O. Pearce wrote:
Steffen Prohaska <prohaska@xxxxxx> wrote:
Shawn,
I attached two patches. They should eventually be both squashed into
one.
Thanks. I'm applying the patch below over both of yours, and
then squashing them all together and keeping you as the author.
I did not like how the listbox looked (or worked!) on Mac OS X.
Clicking on the item was at first a very non-obvious action, and
then when I did do it I was very shocked to see the repository open
immediately. My brain knew the action was wired to the selection
event (I obviously read the two patches before applying them),
but it didn't expect that behavior. Clearly the wrong UI model.
The patch below uses a text widget instead and renders each of
the repositories as a blue underlined link. Users will generally
assume that clicking on such links will take them immediately to
that repository (much as it would take them to another webpage if
this was a web browser)
This is similar to what I had in mind, but was lacking tk knowledge
to implement it.
The "Open Recent Repositories" is not even shown in the UI if there
aren't any to offer to the user. Showing them this area just looks
silly if they haven't opened or cloned anything yet.
We now add freshly created or cloned repositories to the list of
recently opened repositories. These are just as fair game for
being recently accessed as any others. Perhaps even more so as
users may wonder where they cloned that repository to the last time
they started git-gui.
We always store the absolute path of a repository into the config.
This avoids the mess of opening a repository twice using say a
relative path entered into the text entry field and then opening
it later via a file browser, only to find out you now have the same
repository in the recent list twice.
I fixed the --unset-all bug and also avoided the --unset-all/--add
loop you were using. We convert the value into a "safe" expression
and then try to match on it.
That all sound very reasonable to me.
I haven't applied your patch but only read through it. Looks good to me.
Thanks,
Steffen
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
