Re: [PATCH v2] diff --no-index: unleak paths[] elements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ævar,

On Mon, 5 Sep 2022, Ævar Arnfjörð Bjarmason wrote:

> On Mon, Sep 05 2022, Johannes Schindelin wrote:
>
> [...]
> > +	string_list_clear(&to_release, 1);
> [...]
>
>  * The free_util=1 in your code isn't needed/is a bug, we make no use of
>    "util" here, so it should be free_util=0

Calling it a bug is a bit strong, and misses the reason why I did it:
future-proofing.

In any case, René took up Junio's ask and provided a new iteration that
side-steps this concern altogether, therefore the point is now moot.

Ciao,
Johannes

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux