On Fri, Sep 2, 2022 at 2:40 AM Øystein Walle <oystwa@xxxxxxxxx> wrote: > If a line in parseopts's input starts with one of the flag characters it > is erroneously parsed as a opt-spec where the short name of the option > is the flag character itself and the long name is after the end of the > string. This makes Git want to allocate SIZE_MAX bytes of memory at this > line: > > o->long_name = xmemdupz(sb.buf + 2, s - sb.buf - 2); > > Since s and sb.buf are equal the second argument is -2 (except unsigned) > and xmemdupz allocates len + 1 bytes, ie. -1 meaning SIZE_MAX. > > Avoid this by checking whether a flag character was found in the zeroth > position. > > Reported-by: Ingy dot Net <ingy@xxxxxxxx> > Signed-off-by: Øystein Walle <oystwa@xxxxxxxxx> > --- > > Thanks for the review, Eric (should I then add a Reviewed-by trailer?). > Fixed the casing, added the suggested trailer, and remove the > superfluous test_done which indeed was a leftover. Thanks for addressing my minor comments. Since I only scanned my eye over the commit message and patch text, but didn't actually dig into the code to verify if the fix was correct, a Reviewed-by: would be misleading, so let's not add that trailer.
