Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > This series fixes all of the memory leaks in > builtin/submodule--helper.c that our test suite spots, except for > those where the leak is downstream of cmd_submodule__helper() and > caused by code that's not in builtin/submodule--helper.c (e.g. leaks > in the object or config APIs, and in submodule.c). > > This re-roll is on top of the just-now re-rolled v4 of the base > topic[1]. > > Changes in v7: > > * Rebase on top of the base topic. > * Clarify some questions on v6 in updated commit messages. > * Go with Glen's suggested "displaypath" fix. I also tried another > way which the commit discusses. The end result was better, but it > requires further submodule--helper cleanups, and this is already > quite an Odyssey. So FREE_AND_NULL() will do. > > 1. https://lore.kernel.org/git/cover-v4-00.33-00000000000-20220831T230519Z-avarab@xxxxxxxxx > > This series & passing CI can be seen at: > https://github.com/avar/git/tree/avar/submodule--helper-memory-leaks-7 Thanks! And thanks especially for dealing with my stream of comments :) This series + the prep series LGTM. Reviewed-by: Glen Choo <chooglen@xxxxxxxxxx>
