Jonathan Tan <jonathantanmy@xxxxxxxxxx> writes: > "Glen Choo via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: >> diff --git a/refs.c b/refs.c >> index 90bcb271687..d72015c95e9 100644 >> --- a/refs.c >> +++ b/refs.c >> @@ -1784,19 +1784,21 @@ const char *resolve_ref_unsafe(const char *refname, int resolve_flags, >> } >> >> int resolve_gitlink_ref(const char *submodule, const char *refname, >> - struct object_id *oid) >> + struct object_id *oid, const char **referent_out) > > s/referent/target/ throughout this patch, I think. I prefer the word "target", but this is a break from existing conventions, e.g. int refs_read_symbolic_ref(struct ref_store *ref_store, const char *refname, struct strbuf *referent); We can do this change, but I think we should also change this everywhere if we do.