Phillip Wood <phillip.wood123@xxxxxxxxx> writes: > Hi Dscho > > On 01/09/2022 16:42, Johannes Schindelin via GitGitGadget wrote: >> Philippe Blain reported in >> https://lore.kernel.org/git/ecf6f5be-22ca-299f-a8f1-bda38e5ca246@xxxxxxxxx >> that there is a problem when running the built-in version of git add -p with >> diff-so-fancy [https://github.com/so-fancy/diff-so-fancy] as diff colorizer. >> The symptom is this: >> error: could not parse colored hunk header >> '?[36m?[1m?[38;5;13m@ file:1 @?[1m?[0m' >> This patch series addresses that and should fix >> https://github.com/so-fancy/diff-so-fancy/issues/437 >> Changes since v4: >> * The second patch was further simplified, avoiding to print extra >> ANSI >> sequences if the hunk header is shown verbatim. > > That was a quick re-roll! I'm very happy with this version Yeah, looking good.
