Hi Victoria,
On Wed, 31 Aug 2022, Victoria Dye via GitGitGadget wrote:
> From: Victoria Dye <vdye@xxxxxxxxxx>
>
> Add a 'GIT_PERF_USE_SCALAR' environment variable (and corresponding perf
> config 'useScalar') to register a repository created with any of:
>
> * test_perf_fresh_repo
> * test_perf_default_repo
> * test_perf_large_repo
>
> as a Scalar enlistment. This is intended to allow a developer to test the
> impact of Scalar on already-defined performance scenarios.
Great idea!
> [...]
> @@ -130,7 +137,11 @@ test_perf_fresh_repo () {
> "$MODERN_GIT" init -q "$repo" &&
> (
> cd "$repo" &&
> - test_perf_do_repo_symlink_config_
> + test_perf_do_repo_symlink_config_ &&
> + if test_bool_env "$GIT_PERF_USE_SCALAR" false
> + then
> + "$MODERN_SCALAR" register
Do we need to unregister anything here? My guess is that no, the "global"
config we're using in tests is "$TRASH_DIRECTORY/.gitconfig", and the side
effect of scheduling the maintenance task won't matter in practice. But I
might have missed something and we may want to have an explicit
`unregister` step.
What's your take on this?
Ciao,
Dscho
> + fi
> )
> }
