Hi Victoria,
On Wed, 31 Aug 2022, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <johasc@xxxxxxxxxxxxx>
>
> It is merely handing off to `git help scalar`.
>
> Signed-off-by: Johannes Schindelin <johasc@xxxxxxxxxxxxx>
> Signed-off-by: Victoria Dye <vdye@xxxxxxxxxx>
> ---
> scalar.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/scalar.c b/scalar.c
> index 642d16124eb..675d7a6b0a9 100644
> --- a/scalar.c
> +++ b/scalar.c
> @@ -819,6 +819,25 @@ static int cmd_delete(int argc, const char **argv)
> return res;
> }
>
> +static int cmd_help(int argc, const char **argv)
> +{
> + struct option options[] = {
> + OPT_END(),
> + };
> + const char * const usage[] = {
> + N_("scalar help"),
> + NULL
> + };
> +
> + argc = parse_options(argc, argv, NULL, options,
> + usage, 0);
> +
> + if (argc != 0)
> + usage_with_options(usage, options);
> +
> + return run_git("help", "scalar", NULL);
> +}
> +
> static int cmd_version(int argc, const char **argv)
> {
> int verbose = 0, build_options = 0;
> @@ -858,6 +877,7 @@ static struct {
> { "run", cmd_run },
> { "reconfigure", cmd_reconfigure },
> { "delete", cmd_delete },
> + { "help", cmd_help },
Marking this as a tangent ("optional", as some peeps suggested in the Git
standup on IRC [*1*]) with the suggestion to follow up _after_ this here
patch series is done cooking, i.e. once it hits the main branch:
We probably want to migrate `scalar.c` to use the `OPT_SUBCOMMAND` API.
But as I said, please not in this here patch series, so as to separate
concerns properly.
Thanks,
Dscho
> { "version", cmd_version },
> { "diagnose", cmd_diagnose },
> { NULL, NULL},
> --
> gitgitgadget
Footnote *1*:
https://colabti.org/irclogger/irclogger_log/git-devel?date=2022-08-29#l50
