On 31/08/2022 21:04, Junio C Hamano wrote:
> "Eric DeCosta via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
>
[snip]
>> diff --git a/fsmonitor-settings.h b/fsmonitor-settings.h
>> index d9c2605197f..2de54c85e94 100644
>> --- a/fsmonitor-settings.h
>> +++ b/fsmonitor-settings.h
>> @@ -23,12 +23,16 @@ enum fsmonitor_reason {
>> FSMONITOR_REASON_NOSOCKETS, /* NTFS,FAT32 do not support Unix sockets */
>> };
>>
>> +void fsm_settings__set_allow_remote(struct repository *r);
>> +void fsm_settings__set_socket_dir(struct repository *r);
>
> Do these two need to be extern?
>
On 'seen' after building:
...
$ ./static-check.pl >ssc
$ diff nsc ssc
3a4
> bundle-uri.o - for_all_bundles_in_list
15d15
< config.o - git_config_from_file_with_options
40a41,43
> fsmonitor-settings.o - fsm_settings__get_allow_remote
> fsmonitor-settings.o - fsm_settings__get_socket_dir
> fsmonitor-settings.o - fsm_settings__set_allow_remote
44a48
> fsmonitor-settings.o - fsm_settings__set_socket_dir
$
.. so probably not. ;-)
ATB,
Ramsay Jones
