Hi Peff, On Tue, 30 Aug 2022, Jeff King wrote: > On Tue, Aug 30, 2022 at 01:54:23PM +0000, Johannes Schindelin via GitGitGadget wrote: > > > From: Johannes Schindelin <johannes.schindelin@xxxxxx> > > > > The built-in `git add --interactive` does not require Perl, therefore we > > can safely run these tests even when building with `NO_PERL=LetsDoThat`. > > Make sense. The patch is small enough that it is certainly worth doing > in the meantime, but is it time to start thinking about dropping the > perl implementation (and hence this prereq) entirely? A couple of months ago, I would have said the same (and you seemed to suggest something similar in [*1*], too), but since we flipped the default to the built-in version in 0527ccb1b55 (add -i: default to the built-in implementation, 2021-11-30), we discovered the need for several fixes: - pw/add-p-hunk-split-fix - js/add-i-delete - js/add-p-diff-parsing-fix Therefore I consider it premature to drop `git-add--interactive.perl` just yet. Ciao, Dscho Footnote *1*: https://lore.kernel.org/git/YaaP%2Fg74KA63MCmx@xxxxxxxxxxxxxxxxxxxxxxx/
