On 8/29/2022 12:58 AM, Teng Long wrote:
> Derrick Stolee <derrickstolee@xxxxxxxxxx> writes:
>
>> + while (!strbuf_getline(&line, child_out)) {
>> + if (!line.len)
>> + break;
>> + if (!strcmp(line.buf, "get"))
>> + found_get = 1;
>> + }
>
> Clear implementation for me to read, thanks.
>
> I'm not sure but maybe a nit, should it be a "break;" after
> "found_get = 1;" for omitting the left uncencerned capabilities
> to quit earlier?
Teng, you are right that it does not hurt to have a 'break'
here. Since this topic has already merged, that change will
need a forward-fix that I can add to a future series.
Thanks,
-Stolee
