On Sat, Aug 27 2022, Johannes Schindelin via GitGitGadget wrote: > From: Johannes Schindelin <johannes.schindelin@xxxxxx> > [...] > - free((void *)terms->term_good); > - terms->term_good = xstrdup(good); > - free((void *)terms->term_bad); > - terms->term_bad = xstrdup(bad); > + free((void *)terms.term_good); > + terms.term_good = xstrdup(good); > + free((void *)terms.term_bad); > + terms.term_bad = xstrdup(bad); > } This is pre-existing, and dates back to 0f30233a11f (bisect--helper: `bisect_write` shell function in C, 2019-01-02), but it appears this cast to a "void *" was never needed. Perhaps some C++-ism that crept in here? As we're changing this all around perhaps it's worth droppping the cast, or it could be left for some other "remove redundant casts" series.
