"Johannes Schindelin via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > From: Johannes Schindelin <johannes.schindelin@xxxxxx> > > We _already_ have a function to determine whether a given `enum > bisect_error` value is non-zero but still _actually_ indicates success. > > Let's use it instead of duplicating the logic. Yeah, looking very good. > > Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > --- > builtin/bisect--helper.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c > index aa94c25ec73..2f9c7f54f3f 100644 > --- a/builtin/bisect--helper.c > +++ b/builtin/bisect--helper.c > @@ -1380,12 +1380,5 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix) > } > free_terms(&terms); > > - /* > - * Handle early success > - * From check_merge_bases > check_good_are_ancestors_of_bad > bisect_next_all > - */ > - if ((res == BISECT_INTERNAL_SUCCESS_MERGE_BASE) || (res == BISECT_INTERNAL_SUCCESS_1ST_BAD_FOUND)) > - res = BISECT_OK; > - > - return -res; > + return is_bisect_success(res) ? 0 : -res; > }
