Hi Abhradeep,
On Sun, Aug 14, 2022 at 04:55:05PM +0000, Abhradeep Chakraborty via GitGitGadget wrote:
> Changes since v5:
>
> As the failure in the test case is not due to this code, I think it makes no
> sense to delay the patch further.
>
> * The performance test changes were not accurate as the second
> test_bitmap_cases call using the repo built for the previous call. This
> version fixes that.
> * Taylor suggested some minor changes. Those are addressed in this version.
Apologies for my slow reaction time reviewing this series. Between
looking at that preferred pack bug you and Dscho spotted to catching up
after my vacation, it has taken me longer than I wanted to to take a
look at this.
I read through v6 carefully and am happy with the current state of
things. I think there are some small incremental clean-ups that we could
do on top, but they need not block this series, especially since the new
code is made opt-in behind a configuration knob.
This series all looks great to me, and the performance numbers that you
achieved at the end are a nice payoff for all of your hard work. Well
done!
Reviewed-by: Taylor Blau <me@xxxxxxxxxxxx>
Thanks,
Taylor
