On Tue, Aug 23 2022, Derrick Stolee via GitGitGadget wrote: > From: Derrick Stolee <derrickstolee@xxxxxxxxxx> > > GitHub Actions scheduled a brownout of Ubuntu 18.04, which canceled all > runs of the 'static-analysis' job in our CI runs. Update to 22.04 to > avoid this as the brownout later turns into a complete deprecation. > > The use of 18.04 was set in d051ed77ee6 (.github/workflows/main.yml: run > static-analysis on bionic, 2021-02-08) due to the lack of Coccinelle > being available on 20.04 (which continues today). > > Signed-off-by: Derrick Stolee <derrickstolee@xxxxxxxxxx> > --- > ci: update 'static-analysis' to Ubuntu 20.04 > > I noticed this while preparing my bundle URIs series. See an example > cancellation at [1] > > [1] > https://github.com/gitgitgadget/git/runs/7954913465?check_suite_focus=true > > I initially asked about this [2]. Thanks to Matthias Aßhauer for > pointing out that 22.04 has Coccinelle available [3]. > > [2] > https://lore.kernel.org/git/eb8779bc-fc41-f601-05f2-024e6bf3f316@xxxxxxxxxx/ > [3] > https://github.com/gitgitgadget/git/pull/1334#issuecomment-1223597655 > > Thanks, > > * Stolee > > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1334%2Fderrickstolee%2Fstatic-analysis-ubuntu-v1 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1334/derrickstolee/static-analysis-ubuntu-v1 > Pull-Request: https://github.com/gitgitgadget/git/pull/1334 > > .github/workflows/main.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml > index cd1f52692a5..831f4df56c5 100644 > --- a/.github/workflows/main.yml > +++ b/.github/workflows/main.yml > @@ -309,7 +309,7 @@ jobs: > if: needs.ci-config.outputs.enabled == 'yes' > env: > jobname: StaticAnalysis > - runs-on: ubuntu-18.04 > + runs-on: ubuntu-22.04 I think it's worth mentioning in the commit message that the reason we're not going for "ubuntu-latest" here is because "latest" is a misnomer, it's not the "latest", but "latest-stable" or whatever. I.e. it's pointing to 20.04 currently: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources I think per https://lore.kernel.org/git/211104.86v918i78r.gmgdl@xxxxxxxxxxxxxxxxxxx/ that we should pin these in general, but you/Junio disagreed at the time. So maybe a commit message change/comment here noting "# make this ubuntu-latest once it's ubuntu-22.04 or later" or something would make the intent clearer. Also: for "sparse" didn't we miss doing that, i.e. it's pinned on ubuntu-20.04 explicitly, but surely that should be "ubuntu-latest" now?
