Re: [PATCH 2/6] t/lib-bitmap.sh: avoid silencing stderr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Aug 20, 2022 at 10:14:03PM +0530, Abhradeep Chakraborty wrote:
> On Sat, Aug 20, 2022 at 3:00 AM Taylor Blau <me@xxxxxxxxxxxx> wrote:
> > diff --git a/t/lib-bitmap.sh b/t/lib-bitmap.sh
> > index a95537e759..f595937094 100644
> > --- a/t/lib-bitmap.sh
> > +++ b/t/lib-bitmap.sh
> > @@ -440,7 +440,7 @@ midx_bitmap_partial_tests () {
> >                 test_commit packed &&
> >                 git repack &&
> >                 test_commit loose &&
> > -               git multi-pack-index write --bitmap 2>err &&
> > +               git multi-pack-index write --bitmap &&
> >                 test_path_is_file $midx &&
> >                 test_path_is_file $midx-$(midx_checksum $objdir).bitmap
> >         '
>
> Thanks Taylor! I would say this is a very good change. It might have
> been there for some reason when it was written, but that was resisting
> us to debug what was going on ;-)

:-). I was probably doing something with "err" when I originally wrote
this test. But I likely dropped whatever assertion I had written and
forgot to stop redirecting stderr.

Better late than never ;-).

Thanks,
Taylor



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux