On Fri, Aug 19, 2022 at 9:06 PM Derrick Stolee <derrickstolee@xxxxxxxxxx> wrote: > > On 8/19/2022 4:54 AM, Jeff King wrote: > > The reader code passes around a "struct reftable_reader" context > > variable. But the seek function doesn't need it; the table iterator we > > already get is sufficient. > > If we wanted to make it seem more like it was a method of something, > it now looks to operate on the table_iter, so the method name could > change to something like "table_seek_linear()" which might satisfy > both goals. +1. Name should be table_iter_seek_linear to stick with naming conventions, and should move to the top of the file next to other table_iter methods. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Liana Sebastian
