On 8/18/2022 5:40 PM, Victoria Dye via GitGitGadget wrote: > This series enables the built-in FSMonitor [1] on 'scalar'-registered > repository enlistments. To avoid errors when unregistering an enlistment, > the FSMonitor daemon is explicitly stopped during 'scalar unregister'. > > Maintainer's note: this series has a minor conflict with > 'vd/scalar-generalize-diagnose'. Please let me know if there's anything else > I can provide (in addition to [2]) that would make resolution easier. > > > Changes since V2 > ================ > > * Updated prerequisites for FSMonitor in Scalar to include > 'fsm_settings__get_reason(the_repository) == FSMONITOR_REASON_OK' to > handle cases where the platform is supported, but the repository is not. > * Gated enabling the 'core.fsmonitor' on FSMonitor compatibility with the > repo. > * Replaced 'die()' failures in 'delete_enlistment()' with 'error()'s. > * Replaced 'BUILTIN_FSMONITOR' test prerequisite with already-existing > 'FSMONITOR_DAEMON' for FSMonitor. > * Rewrote Scalar enlistment/repo search in 'setup_enlistment_directory()' > to avoid unconstrained search and respect 'GIT_CEILING_DIRECTORIES'. > Added tests to show the new expected behavior. I wrote a couple "thinking out loud" replies, but the series looks good to me without any changes. Thanks, -Stolee
