On Fri, Aug 19 2022, Johannes Schindelin wrote: > On Thu, 18 Aug 2022, Ævar Arnfjörð Bjarmason wrote: > >> On Wed, Aug 17 2022, Junio C Hamano wrote: >> >> > * js/bisect-in-c (2022-06-27) 16 commits >> > - bisect: no longer try to clean up left-over `.git/head-name` files >> > - bisect: remove Cogito-related code >> > - Turn `git bisect` into a full built-in >> > - bisect: move even the command-line parsing to `bisect--helper` >> > - bisect: teach the `bisect--helper` command to show the correct usage strings >> > - bisect--helper: return only correct exit codes in `cmd_*()` >> > - bisect--helper: move the `BISECT_STATE` case to the end >> > - bisect--helper: make `--bisect-state` optional >> > - bisect--helper: align the sub-command order with git-bisect.sh >> > - bisect--helper: using `--bisect-state` without an argument is a bug >> > - bisect--helper: really retire `--bisect-autostart` >> > - bisect--helper: really retire --bisect-next-check >> > - bisect--helper: retire the --no-log option >> > - bisect: avoid double-quoting when printing the failed command >> > - bisect run: fix the error message >> > - bisect: verify that a bogus option won't try to start a bisection >> > >> > Final bits of "git bisect.sh" have been rewritten in C. >> > >> > Expecting a (hopefully final) reroll. >> > cf. <20627.86ilolhnnn.gmgdl@xxxxxxxxxxxxxxxxxxx> >> >> The msgid here is typo'd, the correct one is >> https://lore.kernel.org/git/220627.86ilolhnnn.gmgdl@xxxxxxxxxxxxxxxxxxx/ >> (i.e. a "2" is missing from the front). >> >> The more recent >> https://lore.kernel.org/git/220817.86pmgzabv0.gmgdl@xxxxxxxxxxxxxxxxxxx/ >> also has some more follow-up, and a proposed fix-up for one of the >> issues I noted with the series (the completion helper interaction with >> the new "bisect"). > > So now we should also include changes for the completion into this patch > series? Are you serious? The proposed fix-up is for a part of git.c that only exists with your series applied. Before your series "git bisect--helper" supported "--git-completion-helper" (although not to do anything useful in practice). With your series we have a "bisect" built-in. Built-ins by default claim to support "--git-completion-helper", but as your series also migrated the code away from parse_options() it doesn't anymore. So it makes sense for the relevant patch(es) to update the corresponding flag as that's changed, see also the in-flight 68494127d6c (git.c: update NO_PARSEOPT markings, 2022-07-25).
