On Thu Aug 18, 2022 at 9:54 AM PDT, Junio C Hamano wrote: > So, the updated code mistook the body of the message that is not a > sign-off, because there is a colon on the line, the line does not > begin with the colon, and everything before the colon is an alnum or > a whitespace, so squashed the paragraph break before the real > trailer block and the last line of the body and made it a body-less > commit log message? I agree that it is not ideal, and I'm not sure how to fix it. This commit probably shouldn't go in as-is; I modified the test in order to demonstrate this problem. > This might be a good demonstration of why it is a mistaken design to > allow whitespaces, which may steer us toward fixing the documentation? > > I dunno. What do others think? I think allowing whitespace is good at least for the Phabricator project, which despite being dead, has a number of existing users and existing commits. It unfortunately has a "Differential revision" trailer with whitespace.
